Ticket #37 (new bug)

Opened 1 year ago

Last modified 1 month ago

Infinite loop in Mongrel::Gems::require

Reported by: drbrain Assigned to: evanweaver
Priority: major Milestone: 1.2
Component: Mongrel Keywords: Nike Air Force One, Air Force 1, Air Force One, Air Force Shoes, Nike Air Force 1
Cc:

Description

If the gem is loaded but the file inside it does not exist, mongrel enters an infinite loop between lines 9 and 13.

http://mongrel.rubyforge.org/browser/trunk/lib/mongrel/gems.rb?rev=894#L9 http://mongrel.rubyforge.org/browser/trunk/lib/mongrel/gems.rb?rev=894#L13

PS: The exception message is not checked (line 8) to see if the file the user attempted to load was the one that raised the exception. This makes debugging more difficult, the require should only be retried when it was the one that failed.

Attachments

37-fix-infinite-loop-error-in-gem-require.patch (1.2 kB) - added by matthewrudy on 01/24/09 14:22:42.
Git patch

Change History

11/11/08 05:41:16 changed by storney

PS: The exception message is not checked (line 8) to see if the file the user attempted to load was the one that raised the exception. This makes debugging more difficult, the require should only be retried when it was the one that failed.

others faqs

01/24/09 10:01:26 changed by rarepleasures

  • priority changed from minor to major.

I think this is a major bug. This has been stopping me using mongrel for any of my rails and merb projects. The ./script/server command just hangs.

01/24/09 14:22:42 changed by matthewrudy

  • attachment 37-fix-infinite-loop-error-in-gem-require.patch added.

Git patch

01/24/09 14:24:00 changed by matthewrudy

gosh, yeah. 

matthew@rubuntu:~/projects/mongrel$ irb
irb(main):001:0> require 'lib/mongrel/gems'
=> true
irb(main):002:0> Mongrel::Gems.require("libxml-ruby")

*hangs*

I just attached a one line fix.

03/24/09 08:58:42 changed by sneakeralley

  • keywords set to Nike Air Force One, Air Force 1, Air Force One, Air Force Shoes, Nike Air Force 1.

Nike Air Force One

06/05/09 13:40:53 changed by storney

Ya, this is a major bug.

will stop me using mongrel for any of my rails and merb projects. The ./script/server command just hangs. DeletedBloggersAsks